[Python] Only use Python Limited C API in ROOT Pythonizations library#21766
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Apr 9, 2026
Merged
[Python] Only use Python Limited C API in ROOT Pythonizations library#21766guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
guitargeek
force-pushed
the
limited_api
branch
3 times, most recently
from
94ced7a to
3380aef
Compare
Test Results 22 files 22 suites 3d 4h 25m 48s ⏱️ Results for commit 4003e51. ♻️ This comment has been updated with latest results. |
vepadulano
requested changes
Apr 8, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
I like the overall direction! I have two minor comments that need clarification before moving on.
This follows up on 4e0c7bf, swapping out the remaining use of CPython API functions that were not inside the limited API. In the cases where we're sill using private headers from cppyy, the parts of these headers that don't compile with the limited API are excluded via the `Py_LIMITED_API` preprocessor macro.
Contributor
Author
|
Thanks for the review @vepadulano! I have updated the PR |
Contributor
Author
|
Just to try it out, I made the experiment of building |
vepadulano
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on 4e0c7bf, swapping out the remaining use of CPython API functions that were not inside the limited API.
In the cases where we're sill using private headers from cppyy, the parts of these headers that don't compile with the limited API are excluded via the
Py_LIMITED_APIpreprocessor macro.